fix: post watcher not triggered (fix #12664) #12669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuniorTour
commented
Jul 15, 2022
src/core/observer/scheduler.ts
Outdated
| @@ -156,7 +156,7 @@ function callActivatedHooks(queue) { | |||
| */ | |||
| export function queueWatcher(watcher: Watcher) { | |||
| const id = watcher.id | |||
| if (has[id] != null) { | |||
| if (id !== Infinity && has[id] != null) { | |||
There was a problem hiding this comment.
Infinity id comes from:
Line 316 in 7d4a772
JuniorTour
force-pushed
the
fix-12664-post-watcher
branch
from
4efbac8
to
34e4239
Compare
JuniorTour
force-pushed
the
fix-12664-post-watcher
branch
from
34e4239
to
32f5d56
Compare
yyx990803
reviewed
Jul 16, 2022
|
Thanks for the PR. After looking at the original issue, I think a better fix is to avoid using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Fix #12664