Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): scoped slots can return a single VNode #8644

Closed
wants to merge 1 commit into from

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Aug 12, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No
  • Maybe, but it was wrong to start with

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

@KaelWD KaelWD force-pushed the fix/ScopedSlot-returns-VNode branch from 977f6c2 to 551be9a Compare October 18, 2018 13:17
@yyx990803
Copy link
Member

I think it actually makes more sense to update the implementation to match the types so that it always return arrays. That should also make code more consistent.

Related: #8056

@yyx990803 yyx990803 closed this Oct 23, 2018
@KaelWD
Copy link
Contributor Author

KaelWD commented Dec 3, 2018

I forgot I'd already made this, ended up doing it again in #9131. I agree the implementation could be changed, but until then this change is needed to ensure the types reflect the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants