Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add typings for async components state handling #8988

Closed
wants to merge 2 commits into from
Closed

fix(types): add typings for async components state handling #8988

wants to merge 2 commits into from

Conversation

ivansieder
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@KaelWD
Copy link
Contributor

KaelWD commented Oct 28, 2018

Possible duplicate of #8438?

@ivansieder
Copy link
Author

I guess it is, thanks @KaelWD. Been actually looking through the open RRs, but seems like I've overlooked it!

@ivansieder ivansieder closed this Oct 29, 2018
@KaelWD
Copy link
Contributor

KaelWD commented Oct 29, 2018

Yours might be better though, and has a test which usually helps. Haven't had a good look at either but it seems like #8438 only applies to options.components, not Vue.component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants