Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keep-alive): cache what is really needed not the whole VNode… #9962

Closed
wants to merge 1 commit into from

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented May 1, 2019

cache what is really needed not the whole VNode data. it also fixes #9842
Fixes #2549
Fixes #9972

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@kadet1090
Copy link

Any update on when we can expect this PR to be merged?

@pcm0nk
Copy link

pcm0nk commented May 28, 2020

Can we have an update when this going to be merged? shouldnt this be high priority as it makes the app not usable after some time working and navigating. Also keep-alive has impact on page load. If this gets merged or at least a workaround is provided ( not removing keep-alive) would be nice.

@dyu
Copy link

dyu commented Jun 1, 2020

I just noticed this bug too. The kept-alive node is not being destroyed. This is such a critical bug for a core component that's used by many

lming referenced this pull request in shinyinc/vue Jun 1, 2020
@chencmgithub
Copy link

Any update on when we can expect this PR to be merged?

which version had fixed the bug ??

@RichieChoo
Copy link

Any news?

@posva posva changed the title refactor(keep-alive): cache what is really needed not the whole VNode… fix(keep-alive): cache what is really needed not the whole VNode… Feb 24, 2021
@posva posva added this to Guidance Needed in 2.6.13 Feb 24, 2021
@posva
Copy link
Member

posva commented Apr 16, 2021

@zrh122 Thanks a lot for this! I reopened a new one with a refactor to avoid creating a new function on every render: #12015

@posva posva closed this Apr 16, 2021
2.6.13 automation moved this from Guidance Needed to Done Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
7 participants