Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($theme-default): dropdown should be close when foucsout (fix #2227) #2234

Closed
wants to merge 1 commit into from

Conversation

billyyyyy3320
Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 commented Mar 19, 2020

Summary

Fix #2227

Other approach is adding a foucsout event to the button.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Contributor

@haoranpb haoranpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to break accessibility introduced in #1837

Try to use Tab to navigate to Learn More, and press Enter, the dropdown won't show now.

@billyyyyy3320
Copy link
Collaborator Author

billyyyyy3320 commented Mar 20, 2020

Oops. So, it seems adding a foucsout event to the button will also break that feature, too.

It's more complicated than my first impression. Welcome to any thoughts.

// override the inline style.
display block !important
&.open:blur
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevertheless, AFAIK, there is no :blur pseudo-class in CSS

@Mister-Hope
Copy link
Contributor

@newsbielt703 Your thoughts are a bit complicated. Why don't we just disable the pointer event since hover will do the job.

I think #2303 is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlap on a Navbar Dropdown
3 participants