Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second expression (
repo
) of the ternary operator would never get executed in the refactored implementation, since the value ofdocsRepo
must be a full url (it must contain thebitbucket.org
string), which means that it will always match theoutboundRE
regex pattern (which is/^[a-z]+:/i
(from line 4 ofpackages/@vuepress/theme-default/util/index.js
)), so thebase
variable would always get its initial value fromdocsRepo
.I tried to understand the original intention behind this line, but it just seemed to be wrong to me: if
docsRepo
had been defined by the user asgroup(or user)/project
(likevuejs/vuepress
), then thebase
variable used the value ofrepo
, which is the url of the main site's repo, and not the repo of the docs. Not to mention, that agroup(or user)/project
-styledocsRepo
value suggests aGitHub
repo and not aBitBucket
one.