Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override style issues (close: #637) #638

Merged
merged 1 commit into from Jul 8, 2018

Conversation

ulivz
Copy link
Member

@ulivz ulivz commented Jul 8, 2018

Summary

  1. duplicated generated override style
  2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: Fix CSS ordering for config with multiple entry points webpack-contrib/mini-css-extract-plugin#130)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

1. duplicated generated override style
2. unexpected style order, override style should be at the end of the extracted style bundle. (ref: webpack-contrib/mini-css-extract-plugin#130)
@ulivz ulivz changed the title fix: override style issues fix: override style issues (close: #637) Jul 8, 2018
@ulivz ulivz merged commit f998802 into master Jul 8, 2018
@ulivz ulivz deleted the 637-duplicated-override-css branch July 9, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant