Check existence of module parent in isRegistered (fix #1850)

vuejs · Oct 16, 2020 · 93967bc · 93967bc
1 parent 6b0014c
commit 93967bc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/module/module-collection.js b/src/module/module-collection.js
@@ -72,7 +72,11 @@ export default class ModuleCollection {
     const parent = this.get(path.slice(0, -1))
     const key = path[path.length - 1]
 
-    return parent.hasChild(key)
+    if (parent) {
+      return parent.hasChild(key)
+    }
+
+    return false
   }
 }
 

diff --git a/test/unit/module/module-collection.spec.js b/test/unit/module/module-collection.spec.js
@@ -100,4 +100,18 @@ describe('ModuleCollection', () => {
     collection.unregister(['a'])
     expect(spy).toHaveBeenCalled()
   })
+
+  it('isRegistered', () => {
+    const collection = new ModuleCollection({})
+    collection.register(['a'], {
+      state: { value: true }
+    })
+    collection.register(['a', 'b'], {
+      state: { value: false }
+    })
+    expect(collection.isRegistered(['a'])).toBe(true)
+    expect(collection.isRegistered(['a', 'b'])).toBe(true)
+    expect(collection.isRegistered(['c'])).toBe(false)
+    expect(collection.isRegistered(['c', 'd'])).toBe(false)
+  })
 })