Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup devtools integration #1949

Merged
merged 18 commits into from May 20, 2021
Merged

feat: setup devtools integration #1949

merged 18 commits into from May 20, 2021

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Mar 18, 2021

Closes #1942

@posva
Copy link
Member

posva commented Mar 24, 2021

Screen Shot 2021-03-24 at 15 44 58
Screen Shot 2021-03-24 at 15 44 36

Haven't tested nested modules yet

@Akryum
Copy link
Member Author

Akryum commented Apr 20, 2021

Actions logging
image

@Akryum
Copy link
Member Author

Akryum commented Apr 20, 2021

Store filtering
image

@Akryum Akryum requested review from kiaking and posva April 20, 2021 13:13
@Akryum Akryum marked this pull request as ready for review April 20, 2021 13:19
@Akryum
Copy link
Member Author

Akryum commented Apr 21, 2021

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME WORK GUYS!!!! 🎉 🎉 🎉 🎉 🎉

@Akryum I left 1 comment, I wasn't 100% sure (unused color vars).

Also, what do you think about positioning actions on top of mutations in Timeline view. It's really a personal preference but for me it kinda feels more natural to have actions timeline on top.

Especially when actions are async, having timeline range bar on top of mutations dots might look better...? Again, just my personal preference though 😳

/**
* Extracted from tailwind palette
*/
const COLOR_PINK_500 = 0xec4899
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove other than

  • const COLOR_LIME_500 = 0x22d3ee
  • const COLOR_DARK = 0x666666
  • const COLOR_WHITE = 0xffffff

Since seems like we're not using them...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be my fault lol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK cool! I'll remove it then 👍 I wasn't sure if Devtools was doing some ultra magic to pick these colors up some how haha

@kiaking
Copy link
Member

kiaking commented May 10, 2021

Pushed small code style change and fix linter error. Lint error is still there due to #1949 (comment). Not sure why CI is not picking it up 🤔

package.json Outdated
@@ -54,6 +54,9 @@
"peerDependencies": {
"vue": "^3.0.2"
},
"dependencies": {
"@vue/devtools-api": "^6.0.0-beta.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is added as a dependency, shouldn't we mark it as external too? I will need to follow the same on Vue Router. Currently it is not marked as external and therefor is only a dev dependency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was here to support Type imports in TS...? In that case I think it should be the same in Router too. Am I correct @Akryum ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does nothing except calling a function or putting the plugin into a queue array.

@Akryum
Copy link
Member Author

Akryum commented May 10, 2021

Also, what do you think about positioning actions on top of mutations in Timeline view. It's really a personal preference but for me it kinda feels more natural to have actions timeline on top.

Especially when actions are async, having timeline range bar on top of mutations dots might look better...? Again, just my personal preference though 😳

I don't know, I also thought about it but then the actions layer can grow its height where the mutations will not. So it will probably be pushed far at the bottom if there are a lot of parallel actions going on.

@kiaking
Copy link
Member

kiaking commented May 10, 2021

@Akryum Ah good point. Nice catch. In that case yeah it make sense to have actions under mutations 👍

@kiaking kiaking added 4.x build Related to the build system enhancement New feature or request labels May 20, 2021
@kiaking kiaking merged commit a6bfbb3 into 4.0 May 20, 2021
@kiaking kiaking deleted the feat-devtools branch May 20, 2021 16:27
@kiaking kiaking linked an issue May 20, 2021 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x build Related to the build system enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vuex 4 devtools integration
3 participants