feat: add method to get validation model and it children deeply #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusmcordeiro
changed the title
|
Could you please revert all the unnecessary changes, apart from the actual method to get the models? Your ide probably did those automatically which is unnecessary. |
mateusmcordeiro
changed the title
mateusmcordeiro
changed the title
|
@dobromir-hristov done. |
Comment on lines
+227
to
+231
| * @param {Object} iModel - Internal $model to retrieve the $model for each layer interaction. | ||
| * @param {Object} iChildResults - Internal ChildResults from current layer interaction. | ||
| * @param {Object} iNestedResults - Internal NestedResults from current layer interaction. | ||
| * @returns {Object} - A deep object containing the values of the model and its child and nested results. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| * @param {Object} iModel - Internal $model to retrieve the $model for each layer interaction. | |
| * @param {Object} iChildResults - Internal ChildResults from current layer interaction. | |
| * @param {Object} iNestedResults - Internal NestedResults from current layer interaction. | |
| * @returns {Object} - A deep object containing the values of the model and its child and nested results. | |
| */ | |
| * @param {Object} model - Internal $model to retrieve the $model for each layer interaction. | |
| * @param {Object} childResults - Internal ChildResults from current layer interaction. | |
| * @param {Object} nestedResults - Internal NestedResults from current layer interaction. | |
| * @returns {Object} - A deep object containing the values of the model and its child and nested results. | |
| */ |
| const unwrappedModel = unwrap(model) | ||
|
|
||
| const treatedModel = | ||
| ['object', 'array'].includes(typeof unwrappedModel) && !!unwrappedModel |
There was a problem hiding this comment.
if the typeof is object or array, !! will always be true. I think that second check is not necessary.
|
|
||
| const treatedModel = | ||
| ['object', 'array'].includes(typeof unwrappedModel) && !!unwrappedModel | ||
| ? { value: unwrappedModel } |
There was a problem hiding this comment.
Is the value just to mimic a ref or computed?
Comment on lines
+242
to
+248
| for (const [key, value] of Object.entries(childResults ?? {})) { | ||
| result[key] = value?.$values?.() | ||
| } | ||
|
|
||
| for (const [key, value] of Object.entries(nestedResults ?? {})) { | ||
| result[key] = value?.$values?.() | ||
| } |
There was a problem hiding this comment.
You could merge the two and iterate at once? 🤔
Also why are you iterating over an object that you just built, I dont get that.... cant we just iterate over the childResults?
Comment on lines
+250
to
+253
| return Object.keys(result).length > 0 | ||
| ? { ...treatedModel, ...result } | ||
| : treatedModel | ||
| } |
There was a problem hiding this comment.
do we need this check at all? What if we just spread them always?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I use to use this library on my vue applications, but i aways fell its missing a method to get all the
$modelvalues from all validations and nested children included so i decided to implement it by myself.Metadata
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
nextbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: