Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hero): add w-full to image #3115

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

FRSgit
Copy link
Contributor

@FRSgit FRSgit commented Apr 22, 2024

Related issue

https://github.com/vuestorefront/unified-storefronts/pull/1237#issuecomment-2069309576

Closes #

Scope of work

Without w-full the image behaves weirdly when the container is not 100% width

Screenshots of visual changes

Checklist

  • Self code-reviewed
  • Changes documented
  • Semantic HTML
  • SSR-friendly
  • Caching friendly
  • a11y for WCAG 2.0 AA
  • examples created
  • blocks created
  • cypress tests created

Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: 71cd1f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Szymon-dziewonski
Copy link
Contributor

@FRSgit you need to rebase/merge main into your branch, because file .nvmrc is required for CI

@FRSgit FRSgit merged commit 9b4389a into v2-develop May 23, 2024
16 checks passed
@FRSgit FRSgit deleted the chore/add-w-full-to-hero branch May 23, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants