fix: nuxt module [SFUI2-1327] #3155
Conversation
Szymon-dziewonski
requested review from
FRSgit,
mattmaribojoc,
filrak and
skirianov
as code owners
🦋 Changeset detectedLatest commit: 95f5f84 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| import * as storefrontUi from '@storefront-ui/vue'; | ||
| import { tailwindConfig } from '@storefront-ui/vue/tailwind-config'; | ||
| import { type RawFile } from 'tailwindcss/types/config'; | ||
| import '@nuxtjs/tailwindcss'; |
There was a problem hiding this comment.
without this import NuxtOptions['tailwindcss'] does not work and throw error that tailwindcss does not exists on NuxtOptions, because there is typing file generated on tailwindcss side that NuxtOptions contain this property.
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
from
7edda5f
to
4aed9de
Compare
Szymon-dziewonski
changed the base branch from
v2-develop
to
v2-release/nuxt-2.5.0
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
from
4aed9de
to
2b21954
Compare
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
from
429f4df
to
16d0405
Compare
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
from
b95c197
to
237404f
Compare
|
cannot continue working with PR because of error occurs nuxt/module-builder#267 |
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
from
237404f
to
c5a1e9e
Compare
|
|
||
| ```bash | ||
| # npm | ||
| npm i -D @nuxtjs/tailwindcss @storefront-ui/vue | ||
| npm i -D @storefront-ui/nuxt @storefront-ui/vue @nuxtjs/tailwindcss |
There was a problem hiding this comment.
Question: shouldn't @nuxtjs/tailwindcss be installed by our nuxt module?
There was a problem hiding this comment.
its installed only in nuxt itself modules property in config, however we still need dependency
There was a problem hiding this comment.
dependency in our package.json, right? Not in the user codebase.
Like: @nuxtjs/tailwindcss does not require you to install tailwindcss itself
There was a problem hiding this comment.
dependency in client package.json. If user will install our @storefront-ui/nuxt module, which uses @nuxtjs/tailwindcss wont have it wont work. In other words await installModule('@nuxtjs/tailwindcss'); in out module just adding @nuxtjs/tailwindcss string to nuxt.config.js modules property. It does not installing dependency into package.json. I just double checked it.
There was a problem hiding this comment.
That's why it would be good to have @nuxtjs/tailwindcss as a subdependency of our module, right? IMO it would be a nice thing for the end users - they do not have to install/update @nuxtjs/tailwindcss unless they use it directly by themselves.
Now I'm wondering if we shouldn't do the same for @storefront-ui/vue. Do we need it to be explicitly installed by the user and not as a subdependency of @storefront-ui/nuxt?
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
2 times, most recently
from
264716c
to
de417f0
Compare
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
from
de417f0
to
a56eeb9
Compare
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
from
ef5c503
to
07f894e
Compare
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
15 times, most recently
from
57d7878
to
c30a56b
Compare
Szymon-dziewonski
force-pushed
the
fix--nuxt-module
branch
from
c30a56b
to
72117ed
Compare
Related issue
https://alokai.atlassian.net/browse/SFUI2-1327
Closes #
Scope of work
Fix
nuxtpackageAdd
README.mdfileUpdate installation documentation
Add linting to
nuxtpackageScreenshots of visual changes
Checklist