fix(types): rename emits event variables

Vue automatically names the event key "event" and causes duplicate variable conflicts
vuetifyjs · Apr 10, 2023 · 0709890 · 0709890
1 parent 9655ec4
commit 0709890
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/vuetify/src/components/VImg/VImg.tsx b/packages/vuetify/src/components/VImg/VImg.tsx
@@ -78,9 +78,9 @@ export const VImg = genericComponent<VImgSlots>()({
   },
 
   emits: {
-    loadstart: (event: string | undefined) => true,
-    load: (event: string | undefined) => true,
-    error: (event: string | undefined) => true,
+    loadstart: (value: string | undefined) => true,
+    load: (value: string | undefined) => true,
+    error: (value: string | undefined) => true,
   },
 
   setup (props, { emit, slots }) {

diff --git a/packages/vuetify/src/labs/VDataTable/VDataTableServer.tsx b/packages/vuetify/src/labs/VDataTable/VDataTableServer.tsx
@@ -57,7 +57,7 @@ export const VDataTableServer = genericComponent<VDataTableSlots>()({
     'update:options': (options: any) => true,
     'update:expanded': (options: any) => true,
     'update:groupBy': (value: any) => true,
-    'click:row': (event: Event, value: { item: DataTableItem }) => true,
+    'click:row': (e: Event, value: { item: DataTableItem }) => true,
   },
 
   setup (props, { emit, slots }) {

diff --git a/packages/vuetify/src/labs/VDataTable/VDataTableVirtual.tsx b/packages/vuetify/src/labs/VDataTable/VDataTableVirtual.tsx
@@ -54,7 +54,7 @@ export const VDataTableVirtual = genericComponent<VDataTableVirtualSlots>()({
     'update:options': (value: any) => true,
     'update:groupBy': (value: any) => true,
     'update:expanded': (value: any) => true,
-    'click:row': (event: Event, value: { item: DataTableItem }) => true,
+    'click:row': (e: Event, value: { item: DataTableItem }) => true,
   },
 
   setup (props, { emit, slots }) {