fix(VMenu): don't add button role with openOnHover

fixes #14377
vuetifyjs · Dec 27, 2021 · 24ccd88 · 24ccd88
1 parent 28a64c4
commit 24ccd88
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/packages/vuetify/src/mixins/activatable/__tests__/__snapshots__/activatable.spec.ts.snap b/packages/vuetify/src/mixins/activatable/__tests__/__snapshots__/activatable.spec.ts.snap
@@ -2,8 +2,7 @@
 
 exports[`activatable.ts should render activator slot with hover 1`] = `
 <div>
-  <button role="button"
-          aria-haspopup="true"
+  <button aria-haspopup="true"
           aria-expanded="false"
   >
   </button>

diff --git a/packages/vuetify/src/mixins/activatable/index.ts b/packages/vuetify/src/mixins/activatable/index.ts
@@ -93,7 +93,7 @@ export default baseMixins.extend({
     },
     genActivatorAttributes () {
       return {
-        role: 'button',
+        role: (this.openOnClick && !this.openOnHover) ? 'button' : undefined,
         'aria-haspopup': true,
         'aria-expanded': String(this.isActive),
       }

diff --git a/packages/vuetify/src/mixins/menuable/index.ts b/packages/vuetify/src/mixins/menuable/index.ts
@@ -297,13 +297,15 @@ export default baseMixins.extend<options>().extend({
 
       const onClick = listeners.click
 
-      listeners.click = (e: MouseEvent & KeyboardEvent & FocusEvent) => {
-        if (this.openOnClick) {
-          onClick && onClick(e)
-        }
+      if (onClick) {
+        listeners.click = (e: MouseEvent & KeyboardEvent & FocusEvent) => {
+          if (this.openOnClick) {
+            onClick && onClick(e)
+          }
 
-        this.absoluteX = e.clientX
-        this.absoluteY = e.clientY
+          this.absoluteX = e.clientX
+          this.absoluteY = e.clientY
+        }
       }
 
       return listeners