fix(VCombobox): don't reset search when cleared (#14531)

fixes #14507
vuetifyjs · Dec 27, 2021 · 79cd41d · 79cd41d
1 parent bab2fa2
commit 79cd41d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/vuetify/src/components/VCombobox/VCombobox.ts b/packages/vuetify/src/components/VCombobox/VCombobox.ts
@@ -179,7 +179,7 @@ export default VAutocomplete.extend({
       }
     },
     setValue (value?: any) {
-      VSelect.options.methods.setValue.call(this, value ?? this.internalSearch)
+      VSelect.options.methods.setValue.call(this, value === undefined ? this.internalSearch : value)
     },
     updateEditing () {
       const value = this.internalValue.slice()

diff --git a/packages/vuetify/src/components/VCombobox/__tests__/VCombobox.spec.ts b/packages/vuetify/src/components/VCombobox/__tests__/VCombobox.spec.ts
@@ -298,15 +298,15 @@ describe('VCombobox.ts', () => {
     expect(wrapper.vm.internalValue).toBe('')
 
     wrapper.vm.setValue(null)
-    expect(wrapper.vm.internalValue).toBeUndefined()
+    expect(wrapper.vm.internalValue).toBeNull()
 
     wrapper.vm.setValue(undefined)
     expect(wrapper.vm.internalValue).toBeUndefined()
 
     wrapper.setData({ lazySearch: 'foo' })
 
     wrapper.vm.setValue(null)
-    expect(wrapper.vm.internalValue).toBe('foo')
+    expect(wrapper.vm.internalValue).toBeNull()
 
     wrapper.vm.setValue(undefined)
     expect(wrapper.vm.internalValue).toBe('foo')