fix(VCombobox): compare vs null/undefined as opposed to falsey in sel…

…ectItem fixes #8476
vuetifyjs · Aug 31, 2019 · f53cb81 · KaelWD · Aug 31, 2019 · f53cb81
1 parent db84347
commit f53cb81
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/packages/vuetify/src/components/VCombobox/VCombobox.ts b/packages/vuetify/src/components/VCombobox/VCombobox.ts
@@ -160,7 +160,7 @@ export default VAutocomplete.extend({
       }
     },
     setValue (value?: any) {
-      VSelect.options.methods.setValue.call(this, value || this.internalSearch)
+      VSelect.options.methods.setValue.call(this, value != null ? value : this.internalSearch)
     },
     updateEditing () {
       const value = this.internalValue.slice()

diff --git a/packages/vuetify/src/components/VCombobox/__tests__/VCombobox.spec.ts b/packages/vuetify/src/components/VCombobox/__tests__/VCombobox.spec.ts
@@ -276,4 +276,29 @@ describe('VCombobox.ts', () => {
 
     expect(selectItem).toHaveBeenCalledWith('foo')
   })
+
+  // https://github.com/vuetifyjs/vuetify/issues/8476
+  it('should properly compare falsey values when setting', async () => {
+    const wrapper = mountFunction()
+
+    wrapper.vm.setValue(0)
+    expect(wrapper.vm.internalValue).toBe(0)
+
+    wrapper.vm.setValue('')
+    expect(wrapper.vm.internalValue).toBe('')
+
+    wrapper.vm.setValue(null)
+    expect(wrapper.vm.internalValue).toBeUndefined()
+
+    wrapper.vm.setValue(undefined)
+    expect(wrapper.vm.internalValue).toBeUndefined()
+
+    wrapper.setData({ lazySearch: 'foo' })
+
+    wrapper.vm.setValue(null)
+    expect(wrapper.vm.internalValue).toBe('foo')
+
+    wrapper.vm.setValue(undefined)
+    expect(wrapper.vm.internalValue).toBe('foo')
+  })
 })