Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VItemGroup): add tag prop to component #12771

Merged
merged 7 commits into from
Dec 23, 2020
Merged

feat(VItemGroup): add tag prop to component #12771

merged 7 commits into from
Dec 23, 2020

Conversation

ElijahKotyluk
Copy link
Contributor

@ElijahKotyluk ElijahKotyluk commented Dec 11, 2020

Description

resolves #11392

Motivation and Context

How Has This Been Tested?

Jest | playground

Markup:

<template>
  <v-item-group tag="footer">
    <v-container>
      <v-row>
        <v-col
          v-for="n in 3"
          :key="n"
          cols="12"
          md="4"
        >
          <v-item v-slot="{ active, toggle }">
            <v-card
              :color="active ? 'primary' : ''"
              class="d-flex align-center"
              dark
              height="200"
              @click="toggle"
            >
              <v-scroll-y-transition>
                <div
                  v-if="active"
                  class="display-3 flex-grow-1 text-center"
                >
                  Active
                </div>
              </v-scroll-y-transition>
            </v-card>
          </v-item>
        </v-col>
      </v-row>
    </v-container>
  </v-item-group>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@ElijahKotyluk ElijahKotyluk marked this pull request as ready for review December 14, 2020 21:12
@MajesticPotatoe MajesticPotatoe added the T: feature A new feature label Dec 15, 2020
@johnleider johnleider linked an issue Dec 17, 2020 that may be closed by this pull request
@jacekkarczmarczyk
Copy link
Member

tag may be misleading - it suggest that it's the tag for component itself, not for the item, maybe item-tag would be better?

Also please provide playground for your PRs. Thanks

@ElijahKotyluk ElijahKotyluk changed the title feat(v-item-group): add tag prop to component feat(v-item-group): add item tag to component Dec 20, 2020
@KaelWD KaelWD changed the title feat(v-item-group): add item tag to component feat(VItemGroup): add tag prop to component Dec 23, 2020
@KaelWD
Copy link
Member

KaelWD commented Dec 23, 2020

it suggest that it's the tag for component itself, not for the item

It is for the component though?

@KaelWD KaelWD added this to the v2.4.0 milestone Dec 23, 2020
@KaelWD KaelWD merged commit e3378fc into dev Dec 23, 2020
@KaelWD KaelWD deleted the feat/v-item-group-tag branch December 23, 2020 16:03
@jacekkarczmarczyk
Copy link
Member

It is for the component though?

Ah yeah, i guess i was mislead by some other playground or other piece of code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VItemGroup VItemGroup T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow changing the tag for VBottomNav
4 participants