-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VItemGroup): add tag prop to component #12771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also please provide playground for your PRs. Thanks |
ElijahKotyluk
changed the title
feat(v-item-group): add tag prop to component
feat(v-item-group): add item tag to component
Dec 20, 2020
KaelWD
changed the title
feat(v-item-group): add item tag to component
feat(VItemGroup): add tag prop to component
Dec 23, 2020
It is for the component though? |
KaelWD
reviewed
Dec 23, 2020
KaelWD
force-pushed
the
feat/v-item-group-tag
branch
from
December 23, 2020 16:03
422d259
to
f1702ae
Compare
KaelWD
approved these changes
Dec 23, 2020
Ah yeah, i guess i was mislead by some other playground or other piece of code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #11392
Motivation and Context
How Has This Been Tested?
Jest | playground
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).