Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCombobox): don't reset search when cleared #14531

Merged
merged 1 commit into from Dec 27, 2021
Merged

Conversation

ElijahKotyluk
Copy link
Contributor

@ElijahKotyluk ElijahKotyluk commented Dec 19, 2021

Description

fixes #14507

Motivation and Context

How Has This Been Tested?

visually | unit

Markup:

// Paste your FULL Playground.vue here
<template>
  <v-app>
    input1 @input events={{input1}}
    <v-combobox :items="items" @input="input1++"/>

    input2 @input events={{input2}}
    <v-combobox :items="items" multiple @input="input2++"/>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      input1: 0,
      input2: 0,
      items: [ "item1", "item2", "item3", "item4"]
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@ElijahKotyluk ElijahKotyluk self-assigned this Dec 22, 2021
@ElijahKotyluk ElijahKotyluk marked this pull request as ready for review December 22, 2021 16:32
@KaelWD KaelWD changed the title fix(VCombobox): #14507 fix(VCombobox): don't reset search when cleared Dec 27, 2021
@KaelWD KaelWD merged commit 79cd41d into master Dec 27, 2021
@KaelWD KaelWD deleted the fix/v-combobox-14507 branch December 27, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.6.1] Deleting last character in v-combobox triggers an unexpected input event
2 participants