fix(VBottomNavigation): make it work the input-value prop

[ryo-gk]

Description

The input-value prop was not checked when thresholdmet is invoked.
Fixed that to check the prop then.

Motivation and Context

fixes #11640

How Has This Been Tested?

unit, visually

Markup:

<template>
  <v-app>
    <v-bottom-navigation
      :input-value="show"
      app
    >
      <v-btn >
        <span >test</span>
        <v-icon>mdi-home</v-icon>
      </v-btn>
    </v-bottom-navigation>
    <v-main>
        <v-app-bar style="position: sticky; top: 0;">
          <v-spacer />
          <v-toolbar-title>Title</v-toolbar-title>
          <v-spacer />
        </v-app-bar>
        <v-sheet class="overflow-y-auto">
          {{ sentence.repeat(50) }}
        </v-sheet>
    </v-main>
  </v-app>
</template>

<script>
export default {
  data () {
    return {
      show: true,
      sentence: `Lorem ipsum dolor, sit amet consectetur adipisicing elit. Libero similique
          a harum repellendus maiores, porro aliquid placeat molestiae quos
          molestias? Architecto iure sint quis repudiandae corrupti fugiat dolore.
          Corrupti, unde? Lorem ipsum dolor, sit amet consectetur adipisicing elit.
          Aspernatur ab dicta incidunt natus tenetur dolorum, exercitationem ea
          minus inventore expedita culpa mollitia quam ullam cupiditate magnam error
          accusamus perspiciatis. Possimus.`
    }
  },
}
</script>

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

• The PR title is no longer than 64 characters.
• The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
• My code follows the code style of this project.
• I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

[johnleider]

Thank you for your interest in improving Vuetify. Please create unit tests that correlate to the changes made in this request.

If you have any additional questions, please reach out to us in our Discord community.

[ryo-gk]

I added unit tests (fe37067). Could you check it?

[TravisBuddy]

Hey @ryo-gk,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 95f06fc0-c123-11ea-9c30-6301f8ea01dd

[johnleider]

these tests pass regardless of the branch. we need a test that is going to protect against regression.

[MajesticPotatoe]

pulse check

resolved

[johnleider]

The unit tests pass without the fix and also contains superfluous code, e.g. waiting for the $nextTick.

unit tests do not accurately test the changes

[MajesticPotatoe]

This PR is being closed due to:

• Requested changes not provided (inactivity for 14 days)

Once the requested changes are made, we will reopen and continue the review process. Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community.