Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTheme): Memory leak with vueuse/head #16181

Closed
wants to merge 4 commits into from

Conversation

Denoder
Copy link

@Denoder Denoder commented Nov 28, 2022

Description

Addresses issue: #16156
This alsofixes an issue where if you use useTheme it will not update the styles.

Motivation and Context

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • [ x] The PR title is no longer than 64 characters.
  • [ x] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • [x ] My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some linting issues and the style const doesn't have a nonce property

@johnleider johnleider assigned johnleider and Denoder and unassigned johnleider Nov 29, 2022
@johnleider johnleider added E: theme Theme composable T: bug Functionality that does not work as intended/expected labels Nov 29, 2022
@johnleider johnleider added this to the v3.0.x milestone Nov 29, 2022
@Denoder
Copy link
Author

Denoder commented Nov 29, 2022

Conflicting issues here. addHeadObjs is deprecated in favor of push but when I use it push does not exist. (so had to revert back) Then type HeadAttrs ends up not existing so decide to remove it, and now nonce does not exist. Going to need some pointers here.

@KaelWD KaelWD modified the milestones: v3.0.x, v3.1.x Jan 6, 2023
@KaelWD KaelWD changed the base branch from next to master February 5, 2023 14:26
@KaelWD
Copy link
Member

KaelWD commented Mar 21, 2023

Closing due to inactivity. I updated some stuff in #16721, open a new PR if there's still problems with it.

@KaelWD KaelWD closed this Mar 21, 2023
@KaelWD KaelWD removed this from the v3.1.x milestone Mar 21, 2023
@KaelWD KaelWD added the wontfix The issue is expected and will not be fixed label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: theme Theme composable T: bug Functionality that does not work as intended/expected wontfix The issue is expected and will not be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants