Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(VInput): convert to typescript #5852

Merged
merged 7 commits into from Dec 14, 2018

Conversation

johnleider
Copy link
Member

Description

Convert VInput to typescript.

Motivation and Context

Starting baseline for converting other inputs

How Has This Been Tested?

jest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added T: enhancement Functionality that enhances existing features pending team review The issue is pending a full team review labels Dec 10, 2018
@johnleider johnleider added this to the v1.4.0 milestone Dec 10, 2018
@johnleider johnleider self-assigned this Dec 10, 2018
@vercel
Copy link

vercel bot commented Dec 10, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #5852 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #5852      +/-   ##
=========================================
+ Coverage   88.7%   88.73%   +0.03%     
=========================================
  Files        281      281              
  Lines       6161     6172      +11     
  Branches    1533     1540       +7     
=========================================
+ Hits        5465     5477      +12     
+ Misses       581      580       -1     
  Partials     115      115
Impacted Files Coverage Δ
packages/vuetify/src/components/VInput/index.ts 100% <ø> (ø)
...uetify/src/components/VOverflowBtn/VOverflowBtn.js 94.59% <100%> (ø) ⬆️
...tify/src/components/VAutocomplete/VAutocomplete.js 98.16% <100%> (ø) ⬆️
packages/vuetify/src/mixins/validatable.ts 100% <100%> (ø) ⬆️
packages/vuetify/src/components/VSelect/VSelect.js 88.53% <100%> (ø) ⬆️
...kages/vuetify/src/components/VRadioGroup/VRadio.js 100% <100%> (ø) ⬆️
...uetify/src/components/VRangeSlider/VRangeSlider.js 100% <100%> (ø) ⬆️
.../vuetify/src/components/VRadioGroup/VRadioGroup.js 100% <100%> (ø) ⬆️
packages/vuetify/src/components/VSlider/VSlider.js 99.33% <100%> (ø) ⬆️
...ages/vuetify/src/components/VTextarea/VTextarea.js 93.93% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f54d9b...a043b7a. Read the comment docs.

this.genPrependSlot(),
this.genControl(),
this.genAppendSlot()
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be reverted after #5789

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So next year?

@johnleider johnleider force-pushed the refactor/convert-v-input-to-typescript branch from fdac3e0 to f95b2b1 Compare December 14, 2018 02:53
@johnleider johnleider merged commit 2a81ad0 into dev Dec 14, 2018
@johnleider johnleider deleted the refactor/convert-v-input-to-typescript branch December 14, 2018 20:29
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending team review The issue is pending a full team review T: enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants