Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDialog): Treat 'activator' slot the same wether or not it is a scoped slot. #6116

Closed
wants to merge 1 commit into from

Conversation

Nemikolh
Copy link
Contributor

Description

Change v-dialog__container display property to behave the same when the activator slot is used (whether it is scoped or not).

Note: There is still a difference in that the scoped version doesn't have the v-dialog__activator div.
However this is something that user-code can re-add if it was causing issue.

Motivation and Context

Fix #6115

How Has This Been Tested?

visually

Markup:

<template>
<v-app>
  <v-layout>
    <v-flex>
      <v-dialog><v-btn slot="activator">Test</v-btn></v-dialog>
      <v-dialog><v-btn slot="activator">Test2</v-btn></v-dialog>
    </v-flex>
  </v-layout>
  <v-layout>
    <v-flex>
      <v-dialog><v-btn slot="activator" slot-scope="a">Test</v-btn></v-dialog>
      <v-dialog><v-btn slot="activator" slot-scope="a">Test2</v-btn></v-dialog>
    </v-flex>
  </v-layout>
</v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Jan 11, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nemikolh thanks! I'll approve it after checks pass!

@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #6116 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6116      +/-   ##
==========================================
- Coverage   88.75%   88.69%   -0.07%     
==========================================
  Files         276      276              
  Lines        6287     6288       +1     
  Branches     1584     1585       +1     
==========================================
- Hits         5580     5577       -3     
- Misses        589      593       +4     
  Partials      118      118
Impacted Files Coverage Δ
packages/vuetify/src/components/VDialog/VDialog.js 72.36% <100%> (+0.36%) ⬆️
...fy/src/components/transitions/expand-transition.js 60% <0%> (-16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d4f73...2057234. Read the comment docs.

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@dsseng dsseng added T: bug Functionality that does not work as intended/expected T: enhancement Functionality that enhances existing features labels Jan 11, 2019
@dsseng dsseng added this to the v1.4.x milestone Jan 11, 2019
@KaelWD
Copy link
Member

KaelWD commented Jan 11, 2019

Thanks for the contribution, but I'm going to normalise this behaviour between the different activatable components instead.

@KaelWD KaelWD closed this Jan 11, 2019
@KaelWD KaelWD removed the T: enhancement Functionality that enhances existing features label Jan 11, 2019
@KaelWD KaelWD removed this from the v1.4.x milestone Jan 11, 2019
@KaelWD KaelWD removed the request for review from MajesticPotatoe January 11, 2019 12:49
@Nemikolh
Copy link
Contributor Author

Sounds good. Is there an issue I could follow to track your progress?

@Nemikolh Nemikolh deleted the dialog-slot-scope branch January 11, 2019 13:12
@KaelWD
Copy link
Member

KaelWD commented Jan 11, 2019

#6115

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VDialog activator: display changed to 'block' if slot-scope is used
3 participants