-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VDialog): Treat 'activator' slot the same wether or not it is a scoped slot. #6116
Conversation
This pull request is automatically deployed with Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nemikolh thanks! I'll approve it after checks pass!
Codecov Report
@@ Coverage Diff @@
## master #6116 +/- ##
==========================================
- Coverage 88.75% 88.69% -0.07%
==========================================
Files 276 276
Lines 6287 6288 +1
Branches 1584 1585 +1
==========================================
- Hits 5580 5577 -3
- Misses 589 593 +4
Partials 118 118
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Thanks for the contribution, but I'm going to normalise this behaviour between the different activatable components instead. |
Sounds good. Is there an issue I could follow to track your progress? |
Description
Change
v-dialog__container
display property to behave the same when the activator slot is used (whether it is scoped or not).Motivation and Context
Fix #6115
How Has This Been Tested?
visually
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).