fix(unrefElement): don't return the Vue instance when $el is null/undefined
#1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/`undefined`
When using unrefElement on a template ref of a Vue component which is not available (`v-if="false"`) it returns the Vue instance object with `{ $el: null }`. It should return `null` instead of the Vue instance object.
The cause of this bug is how `plain` is checked to be a VueInstance. Rather than using the value of `$el`, it should check if it has a property named `$el`.
|
added tests |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
unrefElementon a template ref of a Vue component which exposes a custom$el(HeadlessUI]) that points to a not rendered inner ref (v-if="false"),unrefElementreturns the Vue instance object with{ $el: null }. It should returnnullas it should unref the Vue instance ref.The cause of this bug is how
plainis checked to be aVueInstance. Rather than using the value of$el, it should check if it has a property named$el.Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).Update 1: added tests