Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(all)!: isSupported becomes Ref<boolean> instead of boolean for SSR compatibility #1800

Merged
merged 10 commits into from Jul 10, 2022
Merged

fix(all)!: isSupported becomes Ref<boolean> instead of boolean for SSR compatibility #1800

merged 10 commits into from Jul 10, 2022

Conversation

okxiaoliang4
Copy link
Member

Description

fix SSR isSupported

Additional context

from #1598
fixes: #949 #1301

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@okxiaoliang4 okxiaoliang4 changed the title Feature/is supported chore(isSupported)!: fix SSR Jul 8, 2022
@okxiaoliang4 okxiaoliang4 marked this pull request as ready for review July 9, 2022 05:21
antfu
antfu reviewed Jul 9, 2022
View reviewed changes
packages/shared/utils/is.ts Outdated Show resolved Hide resolved
antfu
antfu reviewed Jul 9, 2022
View reviewed changes
packages/shared/utils/is.ts Outdated Show resolved Hide resolved
@antfu antfu changed the title chore(isSupported)!: fix SSR fix(all)!: all isSupported is now ref for SSR compatibility Jul 9, 2022
@antfu antfu changed the base branch from main to next July 9, 2022 07:59
@antfu
Copy link
Member

antfu commented Jul 9, 2022

This is awesome, almost identical to what I was imagined!

On top of the review comment, this PR should target next branch instead of main. I have made the branch switch for this PR but you might need to resolve the conflicts.

@antfu antfu added this to the 9.0 milestone Jul 9, 2022
@antfu antfu changed the title fix(all)!: all isSupported is now ref for SSR compatibility fix(all)!: isSupported is now Ref<boolean> instead of boolean for SSR compatibility Jul 9, 2022
@antfu antfu changed the title fix(all)!: isSupported is now Ref<boolean> instead of boolean for SSR compatibility fix(all)!: isSupported becomes Ref<boolean> instead of boolean for SSR compatibility Jul 9, 2022
@wheatjs
Copy link
Member

wheatjs commented Jul 9, 2022

Awesome work @okxiaoliang4!

@webfansplz
Copy link
Member

Awesome work @okxiaoliang4!

@okxiaoliang4 okxiaoliang4 marked this pull request as draft July 9, 2022 15:01
antfu
antfu approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any leftovers?

@okxiaoliang4
Copy link
Member Author

LGTM. Any leftovers?

No. Is ready to merge :)

@webfansplz webfansplz marked this pull request as ready for review July 10, 2022 04:56
@antfu antfu mentioned this pull request Jul 10, 2022
Closed
8 tasks
@antfu antfu merged commit 81d9225 into vueuse:next Jul 10, 2022
@antfu antfu mentioned this pull request Jul 10, 2022
Closed
9 tasks
@okxiaoliang4 okxiaoliang4 deleted the feature/isSupported branch July 10, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
BREAKING CHNAGE
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

useEyeDropper demo bug
5 participants
@okxiaoliang4 @antfu @wheatjs @webfansplz @onmax