Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useEyeDropper): improve SSR compatibility (#949)(#1301) #1598

Closed
wants to merge 2 commits into from
Closed

fix(useEyeDropper): improve SSR compatibility (#949)(#1301) #1598

wants to merge 2 commits into from

Conversation

zhowiny
Copy link

@zhowiny zhowiny commented May 13, 2022

Description

Visit eyeDropper directly or after refreshing the page isSupported is true but the button is still disabled.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@okxiaoliang4
Copy link
Member

I'm not sure about this. Because isSupported of other functions is also not reactive

@zhowiny
Copy link
Author

zhowiny commented May 13, 2022

I'm not sure about this. Because isSupported of other functions is also not reactive

I found that other functions have similar problems, such as useClipboard. If the above method is determined to be effective, I can fix all places

@antfu
Copy link
Member

antfu commented May 17, 2022

That's a fair point. I will do the refector to change all isSupported to reactive when doing the refactor for the next major release.

@antfu antfu mentioned this pull request Jul 4, 2022
8 tasks
@antfu antfu added this to the 9.0 milestone Jul 6, 2022
@antfu
Copy link
Member

antfu commented Jul 10, 2022

Close in favor of #1800

@antfu antfu closed this Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants