refactor(useSpeechSynthesis)!: remove voiceInfo
, allow voice
as ref
#1882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useSpeechSynthesis demo is not playing the right voice when multiple voices are available for the same language, because we are passing language code instead of a
SpeechSynthesisVoice
object. It wouldn't work even if we pass it asvoice
option, becausevoice
option is static. I changed it toMaybeRef
and this required me to makevoiceInfo
aref
, and this was a breaking change. Then I thought it was pointless to return the same input that we received from users. So, I removed it.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).