Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(useSpeechSynthesis)!: remove voiceInfo, allow voice as ref #1882

Merged
merged 3 commits into from Jul 14, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Jul 13, 2022

Description

useSpeechSynthesis demo is not playing the right voice when multiple voices are available for the same language, because we are passing language code instead of a SpeechSynthesisVoice object. It wouldn't work even if we pass it as voice option, because voice option is static. I changed it to MaybeRef and this required me to make voiceInfo a ref, and this was a breaking change. Then I thought it was pointless to return the same input that we received from users. So, I removed it.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu changed the base branch from main to next July 13, 2022 08:19
@antfu
Copy link
Member

antfu commented Jul 13, 2022

Changed target to next branch, can you rebase it and resolve the conflicts? Thanks

@sibbng sibbng force-pushed the refactor/usespeechsynthesis-voice branch from 2a0190c to 02474c8 Compare July 13, 2022 08:47
@sibbng sibbng force-pushed the refactor/usespeechsynthesis-voice branch from 02474c8 to 91673cc Compare July 13, 2022 09:08
@sibbng
Copy link
Member Author

sibbng commented Jul 13, 2022

Changed target to next branch, can you rebase it and resolve the conflicts? Thanks

Done 👍

@antfu antfu merged commit 011afb2 into vueuse:next Jul 14, 2022
@sibbng sibbng deleted the refactor/usespeechsynthesis-voice branch July 14, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants