feat(useGeolocation): pause and resume controls #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benax-se
force-pushed
the
use-geolocation-start-stop-controls
branch
from
592e87a
to
5975465
Compare
benax-se
changed the title
benax-se
force-pushed
the
use-geolocation-start-stop-controls
branch
from
5975465
to
d8db38f
Compare
sxzz
approved these changes
Oct 29, 2022
9 tasks
sxzz
approved these changes
Nov 1, 2022
1 task
ebisbe
reviewed
Nov 23, 2022
| @@ -7,7 +7,9 @@ import type { ConfigurableNavigator } from '../_configurable' | |||
| import { defaultNavigator } from '../_configurable' | |||
| import { useSupported } from '../useSupported' | |||
|
|
|||
| export interface UseGeolocationOptions extends Partial<PositionOptions>, ConfigurableNavigator {} | |||
| export interface UseGeolocationOptions extends Partial<PositionOptions>, ConfigurableNavigator { | |||
| immediate?: boolean | |||
There was a problem hiding this comment.
Is this doing anything? I don't see it being used
There was a problem hiding this comment.
From the code in #2372
We are missing:
if (immediate)
resume()
so resume() is not always directly called. I can make a PR as I need that feature.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An implementation of #2372
closes #2372
Additional context
None
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).