Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage #2327

Merged
merged 8 commits into from Oct 25, 2022
Merged

test: improve test coverage #2327

merged 8 commits into from Oct 25, 2022

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Oct 17, 2022

Description

All PRs from this branch intend to increase UT coverage and optimize vueuse source code. I will continuously commit test code to this branch.

All commits in this branch are atomic, feel free to merge PR at any time.@antfu

History PRs:

Updated UT Coverage

api statements branches functions lines
createEventHook 100% ⬆️ 100% 100% ⬆️ 100% ⬆️
useTimestamp 100% ⬆️ 100% ⬆️ 100% ⬆️ 100% ⬆️
useNow 100% ⬆️ 100% ⬆️ 100% ⬆️ 100% ⬆️
useEventListener 100% ⬆️ 100% ⬆️ 100% 100% ⬆️
watchThrottled 100% ⬆️ 100% 100% ⬆️ 100% ⬆️
watchDebounced 100% ⬆️ 100% 100% ⬆️ 100% ⬆️

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Test

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

sxzz
sxzz previously approved these changes Oct 19, 2022
@sun0day
Copy link
Member Author

sun0day commented Oct 20, 2022

Build CI failed twice when fetching contributors in node16.x 😭 @sxzz @antfu

image

@sxzz
Copy link
Member

sxzz commented Oct 20, 2022

@sun0day I just triggered to re-run it. It works now. 😄

@sun0day
Copy link
Member Author

sun0day commented Oct 20, 2022

@sun0day I just triggered to re-run it. It works now. 😄

ok

@antfu antfu merged commit a3af5fa into vueuse:main Oct 25, 2022
@sun0day sun0day mentioned this pull request Oct 25, 2022
9 tasks
@younggglcy
Copy link
Contributor

@sun0day Hello, I've found that the tests of watchDebounced have a certain probability of failure in the vue2 environment. This is mainly due to these lines. CI workflows of #2376 and #2386 can be used as reference for your needs.

Can u take some spare time to look at it please? And finally appreciate for your great work and the effort you put!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants