Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useFavicon)!: rename type FaviconOptions to UseFaviconOptions #1865

Merged
merged 1 commit into from Jul 12, 2022
Merged

fix(useFavicon)!: rename type FaviconOptions to UseFaviconOptions #1865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/useFavicon/index.ts
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@ import { watch } from 'vue-demi'
import type { ConfigurableDocument } from '../_configurable'
import { defaultDocument } from '../_configurable'

export interface FaviconOptions extends ConfigurableDocument {
export interface UseFaviconOptions extends ConfigurableDocument {
baseUrl?: string
rel?: string
}
Expand All @@ -18,7 +18,7 @@ export interface FaviconOptions extends ConfigurableDocument {
*/
export function useFavicon(
newIcon: MaybeComputedRef<string | null | undefined> = null,
options: FaviconOptions = {},
options: UseFaviconOptions = {},
) {
const {
baseUrl = '',
Expand All @@ -45,3 +45,5 @@ export function useFavicon(

return favicon
}

export type UseFaviconReturn = ReturnType<typeof useFavicon>