Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fromEvent): support HTMLElement #2048

Merged
merged 3 commits into from Oct 5, 2022
Merged

feat(fromEvent): support HTMLElement #2048

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5856a39
feat(fromEvent): support HTMLElement
Aug 5, 2022
2934553
Update packages/rxjs/from/index.ts
antfu Aug 6, 2022
c7ac6bd
Update packages/rxjs/from/index.ts
Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/rxjs/from/index.ts
View file
Open in desktop
Expand Up @@ -19,9 +19,12 @@ export function from<T>(value: ObservableInput<T> | Ref<T>, watchOptions?: Watch
}
}

export function fromEvent<T extends HTMLElement>(value: Ref<T>, event: string): Observable<Event> {
return from(value, { immediate: true }).pipe(
filter(value => value instanceof HTMLElement),
mergeMap(value => fromEventRx(value, event)),
)
export function fromEvent<T extends HTMLElement>(value: Ref<T> | T, event: string): Observable<Event> {
rorry121 marked this conversation as resolved.
Show resolved Hide resolved
if (isRef<T>(value)) {
return from(value, { immediate: true }).pipe(
filter(value => value instanceof HTMLElement),
mergeMap(value => fromEventRx(value, event)),
)
}
return fromEventRx(value, event);
antfu marked this conversation as resolved.
Show resolved Hide resolved
}