Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useFileDialog): not assign capture to input if value is nullable #2112

Closed
wants to merge 1 commit into from

Conversation

aizigao
Copy link

@aizigao aizigao commented Aug 23, 2022

Description

should not assign capture to input element if value was nullable, this is what happend

codes

<script setup lang="ts">
import { useFileDialog } from '.'

const { files, open, reset } = useFileDialog()
</script>

<template>
  <button type="button" @click="open()">
    Choose files
  </button>
  <button type="button" :disabled="!files" @click="reset()">
    Reset
  </button>
  <template v-if="files">
    <p>You have selected: <b>{{ files.length }} files</b></p>
    <li v-for="file of files" :key="file.name">
      {{ file.name }}
    </li>
  </template>
</template>

before:

normal.video.mp4

after fixed:

normal.video_new.mp4

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@webfansplz
Copy link
Member

Duplicated of #2080 .

@antfu
Copy link
Member

antfu commented Sep 5, 2022

Thanks. Fixed by #2080

@antfu antfu closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants