abandoned(useContextMenu): new function #2136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songjianet
suggested changes
Aug 29, 2022
| @@ -0,0 +1,29 @@ | |||
| import { defineComponent, h, reactive, ref } from 'vue-demi' | |||
| import type { RenderableComponent, UseContextMenuOptions } from '@vueuse/core' | |||
There was a problem hiding this comment.
import type is best placed at the bottom of all references.
|
|
||
| } | ||
|
|
||
| export const UseContextMenu = defineComponent<useContextMenuProps>({ |
There was a problem hiding this comment.
Can useContextMenuProps be written directly as UseContextMenuOptions | RenderableComponent.
| @@ -0,0 +1,139 @@ | |||
| import type { MaybeComputedRef } from '@vueuse/shared' | |||
There was a problem hiding this comment.
import type is best placed at the bottom of all references.
| return { | ||
| visible, | ||
| position, | ||
|
|
There was a problem hiding this comment.
Actually the newline is for separating the state and method since there might be a lot more
property to return.
see core/useManualRefHistory/index.ts#L201
but it's okay to remove it as well, thanks for the suggestions!
| import { ref, watch } from 'vue-demi' | ||
| import type { MaybeElementRef } from '../unrefElement' | ||
| import type { MaybeComputedElementRef } from '../unrefElement' |
There was a problem hiding this comment.
import type is best placed at the bottom of all references.
TODO(done): Fix the edge caseIf clicking on the edge of the page:
|
feat(useWindowSize): support `includeScrollbar` option
feat(useElementSize): support `box` sizing
9 tasks
9 tasks
vaakian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add
contextMenu(s)to the vue app with ease.Redirected to:
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).