Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable pnpm side-effects-cache #2257

Merged
merged 4 commits into from Oct 6, 2022
Merged

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Sep 26, 2022

Description

Just a tip for setup pre-commit using simple-git-hooks

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu
Copy link
Member

antfu commented Sep 26, 2022

Isn't simple-git-hooks already do it automatically?

@sun0day
Copy link
Member Author

sun0day commented Sep 26, 2022

Isn't simple-git-hooks already do it automatically?

In my local host, the pnpm version is 7.12.2. Then side-effects-cache in 7.x is default true while in 6.x is default false. It wont exec dependencies' postinstall when side-effects-cache is true.See

Maybe the right solution is add side-effects-cache=false to .npmrc

@sxzz sxzz changed the title docs(CONTRIBUTING.md): add pre-commit hooks setup docs: add pre-commit hooks setup Sep 26, 2022
@sxzz
Copy link
Member

sxzz commented Oct 4, 2022

Yeah, we can just disable this option.

@sun0day sun0day changed the title docs: add pre-commit hooks setup fix(pnpm): enable simple-git-hooks in pnpm@7.x Oct 6, 2022
@sun0day
Copy link
Member Author

sun0day commented Oct 6, 2022

Yeah, we can just disable this option.

Done. Can you help review another 2 PRs @antfu @sxzz

#2210
#2267

@sxzz sxzz changed the title fix(pnpm): enable simple-git-hooks in pnpm@7.x chore: disable pnpm side-effects-cache Oct 6, 2022
@sxzz sxzz merged commit 494519a into vueuse:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants