Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage #2364

Merged
merged 6 commits into from
Nov 9, 2022
Merged

test: improve test coverage #2364

merged 6 commits into from
Nov 9, 2022

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Oct 25, 2022

Description

All PRs from this branch intend to increase UT coverage and optimize vueuse source code. I will continuously commit test code to this branch.

All commits in this branch are atomic, feel free to merge PR at any time.@antfu

History PRs:

Updated UT Coverage

api statements branches functions lines
useTimeAgo 100% ⬆️ 93.75% ⬆️ 100% ⬆️ 100% ⬆️
useChangeCase 100% ⬆️ 100% ⬆️ 100% ⬆️ 100% ⬆️
useStorage 100% ⬆️ 100% ⬆️ 100% ⬆️ 100% ⬆️
utils/compatibility 100% 100% ⬆️ 100% 100%
useAxios 100% ⬆️ 100% ⬆️ 100% ⬆️ 100% ⬆️

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Test

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sun0day
Copy link
Member Author

sun0day commented Oct 26, 2022

Is there a value type that is Array but not object? @sxzz @antfu

: typeof rawInit === 'object'
? 'object'
: Array.isArray(rawInit)
? 'object'

@sxzz
Copy link
Member

sxzz commented Oct 26, 2022

Hmmm, I think no. We could remove this checking.

@antfu antfu merged commit 65b7bef into vueuse:main Nov 9, 2022
@antfu
Copy link
Member

antfu commented Nov 9, 2022

@sun0day thanks for your continued contribution! Welcome to the team :)

@sun0day
Copy link
Member Author

sun0day commented Nov 9, 2022

@sun0day thanks for your continued contribution! Welcome to the team :)

It's my pleasure. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants