Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useAsyncValidator): incorrect condition for choosing constructor #2788

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

theruziev
Copy link
Contributor

Description

I made a stupid mistake on #2761 馃様, my solution is based on my comment on the issue #2497 (comment).
image

I try to get the constructor from the default attribute (it exists on SSR mode), if doesn't exist use Schema like before PR.
Nothing broke because it didn't work before, but it is good to fix one.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@theruziev
Copy link
Contributor Author

theruziev commented Feb 18, 2023

@okxiaoliang4 sorry for mentioning but you are in context because you review #2761.
I can't provide of example on stackblitz for checking this fix work because stackblitz doesn't permit installation dependencies from github
I checked by editing a file in node_modules and run a project. If you have any idea how I can reproduce an example of this fix or test for this, I listen

@antfu antfu changed the title fix(useAsyncValidator) incorrect condition for choosing constructor fix(useAsyncValidator): incorrect condition for choosing constructor Feb 19, 2023
@antfu antfu merged commit 93b4575 into vueuse:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants