Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useIntersectionObserver): targets length check #2968

Merged
merged 1 commit into from
Apr 14, 2023

fix(useIntersectionObserver): targets length check

fa20a33
Select commit
Failed to load commit list.
Merged

fix(useIntersectionObserver): targets length check #2968

fix(useIntersectionObserver): targets length check
fa20a33
Select commit
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Apr 14, 2023 in 16s

Analysis complete

Summary

Fixed a bug in useIntersectionObserver that caused errors when no targets were provided. Improved the performance and reliability of the function.

Walkthrough

  • Fix early return condition in useIntersectionObserver to avoid unnecessary or invalid calls to observer.observe (link)

Poem

useIntersection
no targets, no observer
a winter silence

Emoji

🐛🚫🚀

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 11.2 seconds
packages/core/useIntersectionObserver/index.ts ✅ Finished 4.1 seconds