Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useDateFormat): Error if Y or YYY provided #3001

Merged
merged 1 commit into from
Apr 20, 2023

fix(useDateFormat): Error if Y or YYY provided

88488bb
Select commit
Failed to load commit list.
Merged

fix(useDateFormat): Error if Y or YYY provided #3001

fix(useDateFormat): Error if Y or YYY provided
88488bb
Select commit
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Apr 19, 2023 in 14s

Analysis complete

Summary

Fixed a bug in useDateFormat that caused undefined output when using custom strings with non-format characters. Improved the error handling of invalid format tokens.

Walkthrough

  • Fix the formatDate function to handle non-format tokens in the input string (link)

Poem

formatDate fixed
Custom strings do not break now
Autumn bug squashed

Emoji

🐛🛠️📝

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 11.8 seconds
packages/shared/useDateFormat/index.ts ✅ Finished 6.4 seconds