fix(useScrollLock): fix scrollable children check #3065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
Scrollable elements check, which has been implemented in #2699, was not working properly, as element's heights were comparing in case of horizontal scroll and widths were comparing in case of vertical scroll. So the check did not pass if an element had vertical scroll, because its
clientWidth
andscrollWidth
remained equalAdditional context
Scroll was not working inside scrollable children with
overflow-x: hidden; overflow-y: auto;
properties🤖 Generated by Copilot at c4d7a86
Fixed a bug in
useScrollLock
hook that caused incorrect behavior for elements with only horizontal scroll. Swapped the order of overflow scroll checks inuseScrollLock/index.ts
.🤖 Generated by Copilot at c4d7a86
isScrollable
function (link) to fix a bug inuseScrollLock
hook