Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useRafFn): set initial delta to zero #3150

Merged
merged 1 commit into from
Jun 28, 2023

fix(useRafFn): set initial delta to zero

7c961cc
Select commit
Failed to load commit list.
Merged

fix(useRafFn): set initial delta to zero #3150

fix(useRafFn): set initial delta to zero
7c961cc
Select commit
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Jun 13, 2023 in 21s

Analysis complete

Summary

Fix NaN delta bug in useRafFn hook. Ensure the callback function receives a valid number as the time difference between frames.

Walkthrough

  • Fix NaN delta bug in useRafFn hook (link)

Poem

useRafFn hook
fixes NaN bug in delta
fall is more precise

Emoji

🐛🕒🚀

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 18.6 seconds
packages/core/useRafFn/index.ts ✅ Finished 5.1 seconds