Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useTimeoutPoll): unexpected immediate execution #3159

Merged
merged 1 commit into from
Jun 28, 2023

fix(useTimeoutPoll): Unexpected immediate execution

7fa971f
Select commit
Failed to load commit list.
Merged

fix(useTimeoutPoll): unexpected immediate execution #3159

fix(useTimeoutPoll): Unexpected immediate execution
7fa971f
Select commit
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Jun 16, 2023 in 13s

Analysis complete

Summary

Fixed a bug in useTimeoutPoll that caused the polling function to run immediately. Added an option to useTimeoutFn to delay the first execution.

Walkthrough

  • Prevent polling function from running immediately on the first call by passing { immediate: false } option to useTimeoutFn (link). This fixes a bug reported in issue #674 and allows the user to control when to start the polling by calling the start function returned by useTimeoutPoll.

Poem

useTimeoutFn waits
no immediate polling
user starts in fall

Emoji

🐛🛠️🚀

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 11 seconds
packages/core/useTimeoutPoll/index.ts ✅ Finished 3.9 seconds