Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useMediaQuery): only add/remove event listeners on query change #3236

Merged
merged 6 commits into from
Jul 30, 2023
Merged

fix(useMediaQuery): only add/remove event listeners on query change #3236

merged 6 commits into from
Jul 30, 2023

Commits on Jul 30, 2023

  1. fix(useMediaQuery): only add/remove event listeners on query change

    @Ingramz
    Ingramz committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    a1823e3 View commit details
    Browse the repository at this point in the history

  2. refactor(useMediaQuery): assert window.matchMedia returns truthy value 

    Falsy checks are a remnant from previous versions of the code before isSupported was introduced, where code path existed that skipped calling window.matchMedia.
    @Ingramz
    Ingramz committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    330fd8b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-use-media-query

    @antfu
    antfu committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    f85c4b9 View commit details
    Browse the repository at this point in the history

  4. test(useWindowSize): change window.matchMedia mock to return MediaQue… 

    …ryList
    @Ingramz
    Ingramz committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    a398ea2 View commit details
    Browse the repository at this point in the history

  5. chore: add --glob parameter to rimraf 

    Fixes "Error: Illegal characters in path." on Windows
    @Ingramz
    Ingramz committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    c477ce8 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix-use-media-query

    @Ingramz
    Ingramz committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    23dfd93 View commit details
    Browse the repository at this point in the history