New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(createInjectionState): add defaultValue option #3902
Open
melishev
wants to merge
1
commit into
vueuse:main
Choose a base branch
from
melishev:main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Apr 1, 2024
melishev
force-pushed
the
main
branch
2 times, most recently
from
April 1, 2024 11:25
c53d4da
to
8f5c4a4
Compare
This is useful pls approve |
I need this!!!! |
Please, approve it!! I need it too!! 🤩 |
mobdiz
approved these changes
Apr 1, 2024
This is a necessary feature for me 👍🏼 |
Alfred-Skyblue
requested changes
Apr 2, 2024
@Alfred-Skyblue can u check pls again? |
Alfred-Skyblue
approved these changes
Apr 8, 2024
@antfu bro, can you upload this PR, I'm getting tired of seeing warning in my console |
Hi, could someone please tell me when this PR will be merged? I need it for my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
When using
inject
from vue, we can pass it a second argumentdefaultValue
, which will help avoid problems and most importantly an error in the console that the provide context was not detected. I propose to extendcreateInjectionState
to support this functionalityAdditional context
Perhaps we should provide the ability to pass defaultValue not only when declaring a hook, but also when using
useInjectedState
.