Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Support for pnpm #76

Closed
1 task done
xeho91 opened this issue Sep 20, 2021 · 3 comments · Fixed by #91
Closed
1 task done

[FEATURE REQUEST] Support for pnpm #76

xeho91 opened this issue Sep 20, 2021 · 3 comments · Fixed by #91
Assignees
Labels
🤝 Contributions Welcome Not on the roadmap but can be picked up by someone 🙏 Feature Request Feature requests not planned anywhere

Comments

@xeho91
Copy link

xeho91 commented Sep 20, 2021

Issues

  • I have checked existing issues and there are no existing ones with the same request.

Feature description

Support for pnpm.

Help

Yes, but I don't know how to start. I would need guidance

Implementation help

This plugin automatically detects npm and yarn.

I would like to help to contribute to add support for the pnpm.

@xeho91 xeho91 added the 🙏 Feature Request Feature requests not planned anywhere label Sep 20, 2021
@vuki656
Copy link
Owner

vuki656 commented Sep 21, 2021

Hey, thanks for the suggestion,

currently, for both yarn and npm, npm outdated is being run since the output is the same.

I see that pnpm also has outdated cli command so you could probably add another detection method for pnpm, and based on that run pnpm outdated --json and just make sure it arrives in the same JSON format as currently expected.

  • Here is the package manager detection
  • Here is the cli call. You would run pnpm outdated --json here, just make sure the output format is the same as for npm

Let me know if you need more info to get started.

@xeho91
Copy link
Author

xeho91 commented Sep 23, 2021

Hey, thanks for the suggestion,

currently, for both yarn and npm, npm outdated is being run since the output is the same.

I see that pnpm also has outdated cli command so you could probably add another detection method for pnpm, and based on that run pnpm outdated --json and just make sure it arrives in the same JSON format as currently expected.

* [Here](https://github.com/vuki656/package-info.nvim/blob/7f5d4f8583de1eaf1ae998c369cb1c81565205d7/lua/package-info/config.lua#L67) is the package manager detection

* [Here](https://github.com/vuki656/package-info.nvim/blob/7f5d4f8583de1eaf1ae998c369cb1c81565205d7/lua/package-info/modules/core.lua#L19) is the cli call. You would run `pnpm outdated --json` here, just make sure the output format is the same as for `npm`

Let me know if you need more info to get started.

Thank you!

I'll start working on it on the upcoming weekend :)

@vuki656 vuki656 added the 🤝 Contributions Welcome Not on the roadmap but can be picked up by someone label Oct 30, 2021
@mtoohey31
Copy link
Contributor

I'm interested in helping too, not sure if you've gotten started. It looks like pnpm doesn't support --json for outdated, but we can just use npm as well. Here's the link to the relevant issue at pnpm's repos though, if this is resolved we might want to do it with pnpm in case it can do things faster, when it's supported.

@vuki656 vuki656 self-assigned this Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤝 Contributions Welcome Not on the roadmap but can be picked up by someone 🙏 Feature Request Feature requests not planned anywhere
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants