-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pnpm #91
Conversation
Oh also, do you want me to add pnpm to the docs everywhere, or just to the parts where it explains what command it runs? |
Really cool, thanks for the contribution. Please do add docs so people know it's supported. Regarding the As for the |
Will do!
After I select the result in either window, I get the following error:
Sounds good! |
Actually, my bad, it turns out I did make a mistake and the error resulting after selecting either window was a bug in my new code for |
Ok, pnpm-related issues are fixed, and docs are updated! Like I said, I'll try and look into the duplicate windows issue, but I believe it's unrelated to these changes since it also happens with npm. |
Does that happen every time when you open the |
My appologies, the double window bug was a result of a failed attempt on my part to solve #86, as you can see by my comment on your issue, I had completely misunderstood what that check regarding the value being Sorry again, I should've been working on that on a separate branch instead of trying to do multiple things at once, lesson learned. |
No problemo :) I'm a bit busy at the moment but feel free to open a PR and I'll take a look within a few days. |
No worries, it's open at #92 when you have time. |
Hey, I just added some tests for command retrieval and loading status. Pretty straightforward stuff. Could you please merge |
Sure, that's done and seems to be working. |
Just merged #92, is this ready as well? |
I believe so! I've been using it since I wrote it, and haven't run into any more issues. |
Cool, thanks for the PR. |
Hello! This PR adds support for pnpm, I believe I've covered all the places where changes are necessary but let me know if I missed anything. I've tested every command except
change_version
because I'm running into issues with that, I believe they're unrelated because it looks like it's creating two version select windows or something like that, not sure, but more research is required before I open an issue for that.Closes #76. As I mentioned in that issue, we can just use
npm outdated --json
to check outdated, since pnpm doesn't support it yet, but we should keep an eye on the issue in the pnpm repo and probably allow it to use pnpm when it's supported.