Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: Bump ava from 5.3.1 to 6.1.3. Bump geckodriver from 3.2.0 to 4.4.0. Bump selenium-webdriver from 4.14.0 to 4.20.0 #3022

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Infrastructure: Bump ava from 5.3.1 to 6.1.3. Bump geckodriver from 3.2.0 to 4.4.0. Bump selenium-webdriver from 4.14.0 to 4.20.0 #3022

merged 2 commits into from
Jun 3, 2024

Conversation

evmiguel
Copy link
Contributor

@evmiguel evmiguel commented May 16, 2024 •
edited by daniel-montalvo

@evmiguel evmiguel added Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation dependencies Pull requests that update a dependency file in a third-party package labels May 16, 2024
@daniel-montalvo daniel-montalvo mentioned this pull request May 16, 2024
Closed
@evmiguel evmiguel requested a review from howard-e May 16, 2024 17:03
@evmiguel evmiguel marked this pull request as ready for review May 16, 2024 17:04
@evmiguel evmiguel changed the title Infrastructure: Bump ava from 5.3.1 to 6.1.3. Bump geckodriver from 3.2.0 to 4.4.0. Bump selenium-webdriver from 4.14.0 to 4.20. Infrastructure: Bump ava from 5.3.1 to 6.1.3. Bump geckodriver from 3.2.0 to 4.4.0. Bump selenium-webdriver from 4.14.0 to 4.20.0 May 16, 2024
howard-e
howard-e approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evmiguel this is great! Thanks for grouping this all together.

Also something of note this fixes (for me) is that when running npm run regression on MacOS, I had to manually set the path to the Firefox binary locally (perhaps the default location(s) for firefox had changed over time). This no longer requires that!

@howard-e howard-e merged commit d080f2a into main Jun 3, 2024
25 checks passed
@howard-e howard-e deleted the upgrade-ava-geckodriver-selenum branch June 3, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file in a third-party package Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evmiguel @howard-e