Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag custom-state-pseudo-class as discontinued #1164

Merged
merged 2 commits into from
May 28, 2024

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Dec 26, 2023

The WICG spec moved to actual standardization with two parts:

  1. The IDL part was moved to HTML in Add custom state pseudo class whatwg/html#8467
  2. The CSS part is to be integrated in Selectors, see [selectors] Custom state pseudo class proposal csswg-drafts#4805

This flags the spec as obsoleted by these two specs, using selectors-4 for the CSS part. The CSS WG resolution mentions Selectors 5 but it does not exist yet. Alternatively, we could keep this PR open until the CSS part gets specified, or not mention selectors-4 at all for now. Not sure which is better. Merging earlier rather than later would help with Webref (to remove the duplicate IDL).

The WICG spec moved to actual standardization with two parts:

1. The IDL part was moved to HTML in whatwg/html#8467
2. The CSS part is to be integrated in Selectors, see w3c/csswg-drafts#4805

This flags the spec as obsoleted by these two specs, using `selectors-4` for
the CSS part. The CSS WG resolution mentions Selectors 5 but it does not exist
yet.
specs.json Outdated
"standing": "discontinued",
"obsoletedBy": [
"html",
"selectors-4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"selectors-4"
"selectors-5"

As annoying as it is, I think the right solution is not to merge this until the CSS bits actually surface in a new css-selectors-5; at least, here is my reasoning:

  • neither the spec nor the repo are marked as discontinued
  • clearly the HTML spec has taken over the IDL bit, but this is properly taken care of by your patch in https://github.com/w3c/webref/pull/1119/files
  • you can't quite make sense of the feature without what's described in the spec until it gets moved into the new CSS selector 5 spec
  • referencing css-selectors-4 when it doesn't actually describe the feature doesn't really help anyone

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Let's park this for now!

@dontcallmedom dontcallmedom marked this pull request as draft January 8, 2024 18:22
@dontcallmedom
Copy link
Member

https://wicg.github.io/custom-state-pseudo-class/ now redirects to the HTML spec, which breaks the webref patch.

Given there is no sign of imminent progress on css-selectors-5, I guess we should make the spec obsoletedby html only at this point, and file an issue to add the new selectors spec when it arises. I'll update the PR in that direction.

it should also be marked as obsolted by css-selectors-5 see #1337
@dontcallmedom dontcallmedom marked this pull request as ready for review May 28, 2024 11:35
@dontcallmedom dontcallmedom merged commit 9ffc380 into main May 28, 2024
1 check passed
@dontcallmedom dontcallmedom deleted the custom-state-pseudo-class branch May 28, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants