Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update report title. #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update report title. #79

wants to merge 2 commits into from

Conversation

BigBlueHat
Copy link
Member

Old title was specific to a single cryptosuite, but these tests
now include tests for three ECDSA cryptosuites.

Old title was specific to a single cryptosuite, but these tests
now include tests for three ECDSA cryptosuites.
@@ -165,7 +165,7 @@ The `implementations` array may contain more than one implementation object, to
test multiple implementations in one run.

```js
// .localConfig.cjs defining local implementations
// localConfig.cjs defining local implementations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// localConfig.cjs defining local implementations
// localConfig.cjs defines local implementations

@@ -165,7 +165,7 @@ The `implementations` array may contain more than one implementation object, to
test multiple implementations in one run.

```js
// .localConfig.cjs defining local implementations
// localConfig.cjs defining local implementations
// you can specify a BASE_URL before running the tests such as:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// you can specify a BASE_URL before running the tests such as:
// you can specify a BASE_URL when running the tests such as:

Copy link
Collaborator

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided the suggests from @TallTed are addressed and we're ok with Data Integrity being dropped from the title approving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants