For publication / deploy on Tuesday October 2, 2023 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A forthcoming change to APG will add a relative-source `<iframe>` element to the APG's "Feed" example page [1]. Update the build script to transform this value using the mechanism established for other types of resources. [1] w3c/aria-practices#2775
Rewrite iframe source attributes in APG
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for the clear documentation of the changes! Looks like this is a new file: https://deploy-preview-268--aria-practices.netlify.app/aria/apg/about/contributing/ In case I forget, let's check it gets added properly. I might need to do an extra step. |
|
@shawna-slh These are all routine changes but indeed that's a new "Contributing" page. Thus the new file. Thanks for flagging this so that we are all in the same page. |
|
Published/deployed. https://www.w3.org/WAI/ARIA/apg/about/contributing/ is there. |
|
Thanks, @shawna-slh !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @shawna-slh. We would like to deploy a new version of the APG as requested by @mcking65 through a recent email thread.
The update includes the following, as sourced from Status of Site Updates > Changes ready for next publication and October 2, 2023 w3c#aria-practices commits:
Listbox Examples: Update scrolling of listbox item with focus into view when page is magnified (pull #2622)
By jongund on Sep 18, 2023
In the listbox examples, fixes #2545 with the following changes:
While fixing this bug, the following additional changes were also made to improve code quality and implement the latest APG code guide practices:
event.keyinstead ofevent.keyCodefor identifying keyboard commands.classconstructors instead ofprototype.mousedownevent topointerdownevent to support mobile devices.aria-activedescendant.Co-authored-by: Matt King a11yThinker@gmail.com
Co-authored-by: Mike Pennisi mike@mikepennisi.com
Co-authored-by: Aleena 55119766+aleenaloves@users.noreply.github.com
Co-authored-by: Howard Edwards howarde.edwards@gmail.com
View commit eed124a
Treegrid Pattern keyboard section: Correct text for Control + Home/End (pull #2779)
By andrewnicols on Sep 18, 2023
For Control+Home and Control+End, The text in the treegrid pattern differed from the text in the treegrid
example. The text in the treegrid pattern didn't make sense because a column only contains one cell so moving focus to the first cell in a column is meaningless. The behaviour and text on the example page are consistent and make logical
sense. This commit makes the pattern and example pages consistent with each other.
Inaccurate text:
If focus is on a cell, moves focus to the first cell in the column.
If focus is on a cell, moves focus to the last cell in the column.
Corrected text:
If focus is on a cell, moves focus to the cell in the first row in the same column as the cell that had focus.
If focus is on a cell, moves focus to the cell in the last row in the same column as the cell that had focus.
View commit 3b17ee7
Navigation Treeview Example: Correct typo: change 'an' to 'and' in accessibility features (pull #2776)
By sdvg on Sep 18, 2023
Incorrect text:
Corrected text:
View commit 1f2e462
11 Example pages: Fix typo in accessibility features: change 'an' to … (pull #2803)
By mcking65 on Sep 20, 2023
Replace 'an' with 'and' in the accessibility features description of high contrast support of focus indicator in 11 examples.
Incorrect text:
Corrected text:
Examples changed:
View commit a92b380
Developing a Keyboard Interface Practice (pull #2805)
By davidlj95 on Sep 20, 2023
Add missing
kbdelement to macOS re-do command in 'Key Assignment Conventions for Common Functions'View commit 7b0b4d3
Multiple Combobox Examples: Adjust input height so text is fully visible in Safari on iOS (pull #2780)
By andreancardona and ariellagilmore on Oct 2, 2023
Resolves #2778 by revising CSS for the following 4 combobox examples so that the space for the input is tall enough to fit the text when viewed in Safari on iOS. Previously, the tops of the letters were chopped off.
View commit 2b619c1
About Section: Add a page about contributing and APG TF membership (pull #2734)
By mcking65 on Oct 2, 2023
Resolves #2706 by adding a new page providing instructions for contributing to the APG. It describes each of the contribution channels and describes how to utilize each of them.
Co-authored-by: Jon Gunderson jongund@illinois.edu
Co-authored-by: Daniel Montalvo 49305434+daniel-montalvo@users.noreply.github.com
Co-authored-by: JaEun Jemma Ku a11ydoer@gmail.com
View commit 7fb7c8e