Skip to content

Commit

Permalink
errors: change timeout errors from 408 to 500 HTTP status code
Browse files Browse the repository at this point in the history
Whilst it is logically correct to use 408 for the timeout and script
timeout errors, it causes a collision with HTTP semantics implement
in HTTP clients.  To support Keep-Alive we allow retries in HTTP
clients and if a client sees code 408 it thinks that the server has
gone away and retries the request.

This causes Execute Script, Navigate To, and Refresh commands to
be sent twice with some HTTP clients.

This is a backwards incompatible change to WebDriver in order to
not break HTTP/1.1 Keep-Alive.

Fixes: #1287
  • Loading branch information
andreastt authored and AutomatedTester committed Sep 3, 2018
1 parent 14266eb commit c377c21
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions index.html
Expand Up @@ -1728,7 +1728,7 @@ <h3>Handling Errors</h3>

<tr>
<td><dfn>script timeout</dfn>
<td>408
<td>500
<td><code>script timeout</code>
<td>A script did not complete before its timeout expired.
</tr>
Expand All @@ -1750,7 +1750,7 @@ <h3>Handling Errors</h3>

<tr>
<td><dfn>timeout</dfn>
<td>408
<td>500
<td><code>timeout</code>
<td>An operation did not complete before its timeout expired.
</tr>
Expand Down

0 comments on commit c377c21

Please sign in to comment.