Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“¦ Release @webref/events@1.11.3 #1231

Merged
merged 1 commit into from May 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 10, 2024

⚠ NEVER add commits to this pull request.

πŸ€– This pull request was automatically created to facilitate human review of @webref/events changes triggered by curated data at 927e7fe.

🧐 Please review the diff below and version numbers. If all looks good, merge this pull request to release the changes to npm.

πŸ“¦ Latest released @webref/events package was v1.11.2. Merging this pull request will release v1.11.3. Make sure that the bump is the right one for the changes.

✍ If any change needs to be made before release, do not add a commit to this pull request. Changes should rather be handled in a separate pull request and pushed to the main branch. You may leave this pull request open in the meantime, or close it. The pre-release job will automatically update this pull request or create a new one once the updates have made their way to the main branch.

πŸ›ˆ The actual change introduced by this pull request is a version bump in packages/events/package.json. You do not need to review that change. The bumped version is not the version that will be released when this pull request is merged, but rather the version that will be released next time.

diff --ignore-trailing-space '--exclude=package.json' '--exclude=README.md' '--exclude=CHANGELOG.md' '--unified=3' webref/node_modules/@webref/events/events.json packages/events/events.json
--- webref/node_modules/@webref/events/events.json
+++ packages/events/events.json
@@ -771,11 +771,12 @@
       }
     ],
     "interface": "Event",
-    "cancelable": true
+    "cancelable": false
   },
   {
     "type": "cancel",
     "interface": "Event",
+    "cancelable": true,
     "targets": [
       {
         "target": "CloseWatcher"

@github-actions github-actions bot force-pushed the release-events-20240510063758100 branch 18 times, most recently from cfb1ad9 to 3dbc9c4 Compare May 14, 2024 18:35
@github-actions github-actions bot force-pushed the release-events-20240510063758100 branch 5 times, most recently from 8e5b579 to 401a0ee Compare May 17, 2024 12:44
@tidoust
Copy link
Member

tidoust commented May 17, 2024

The "cancel" update is not quite correct (but then, the current info is incorrect too, oh well...), see #1237

@github-actions github-actions bot force-pushed the release-events-20240510063758100 branch from 401a0ee to 9823669 Compare May 17, 2024 18:09
@github-actions github-actions bot force-pushed the release-events-20240510063758100 branch from 9823669 to 3e2b1f8 Compare May 17, 2024 18:35
@tidoust tidoust merged commit c9bfa38 into main May 17, 2024
@tidoust tidoust deleted the release-events-20240510063758100 branch May 17, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant